-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed handling repeatable groups wrapped with regular ones #6105
Conversation
e2730fb
to
f670f10
Compare
Given that @grzesiek2010 has flagged this as risky, I'll wait to merge until after testing. |
…layed in the hierarchy
f670f10
to
1193beb
Compare
There is a difference between the way group/ repeats are shown in |
To me the PR version works correctly and what you see on the master branch and older versions was wrong, for example the duplicate section |
Tested with Success! Verified on a device with Android 10 Verified Cases:
|
Tested with Success! Verified on a device with Android 14 |
Closes #6015
Why is this the best possible solution? Were any other approaches considered?
We had at least two issues with this case when a repeatable group was wrapped with a regular one:
I think I've fixed both issues using the appropriate form index.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The pr is not big but I find it risky. We need to test the hierarchy view with nested groups (repeatable and regular ones) to make sure they are displayed in the correct way. @dbemke @srujner @WKobus please be creative and create your own forms ideally with multiple levels of nested groups.
Do we need any specific form for testing your changes? If so, please attach one.
The form I've attached in this comment: #6015 (comment)
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still pass